-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: add icon with yellow stroke #2199
base: master
Are you sure you want to change the base?
Conversation
nice looking |
Which is visible on both dark and light backgrounds
872470b
to
8246266
Compare
It doesn't look quite right to me. Maybe if the outline was thinner or had an alpha gradient? Is this change only for the favicon, or do you have another reason? |
For the favicon in the first place. Maybe there are other places it can be useful in. |
I have picked width that looked the best to me at 16px width (the ones in the table). You can play around with it in the dev tools as well. |
Hey, I also just learned that you can set different favicons depending on color scheme, with the |
@WofWca I assume you're talking about |
It's hard to see the current one on dark background, so.
Closer look (yes, the stroke overflows the canvas):
TODO:
I'll do these if you like the change.