Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add icon with yellow stroke #2199

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WofWca
Copy link
Contributor

@WofWca WofWca commented Dec 17, 2022

It's hard to see the current one on dark background, so.

Before After
old on white new on white
old on black new on black

Closer look (yes, the stroke overflows the canvas):

image

TODO:

  • Replace the favicon.
  • Generate PNGs.
  • Search for occurrences of "icon-v2_black" in the codebase and replace where appropriate.
  • Consider white stroke instead of yellow.

I'll do these if you like the change.

@trebmuh
Copy link
Member

trebmuh commented Dec 17, 2022

nice looking

@Changaco
Copy link
Member

It doesn't look quite right to me. Maybe if the outline was thinner or had an alpha gradient?

Is this change only for the favicon, or do you have another reason?

@WofWca
Copy link
Contributor Author

WofWca commented Dec 20, 2022

For the favicon in the first place. Maybe there are other places it can be useful in.

@WofWca
Copy link
Contributor Author

WofWca commented Dec 20, 2022

Maybe if the outline was thinner or had an alpha gradient?

I have picked width that looked the best to me at 16px width (the ones in the table). You can play around with it in the dev tools as well.
For the gradient - currently I'm not sure how to achieve it.

@WofWca
Copy link
Contributor Author

WofWca commented Dec 25, 2022

Hey, I also just learned that you can set different favicons depending on color scheme, with the media attribute

@Changaco
Copy link
Member

@WofWca I assume you're talking about prefers-color-scheme. It doesn't seem to work on favicons in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants