fix regression

lekoala · Dec 23, 2021 · 0417808 · 0417808
1 parent f8c7a5d
commit 0417808
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bootstrap5-tags",
-  "version": "1.3.2",
+  "version": "1.3.3",
   "description": "Replace select[multiple] with nices badges",
   "main": "tags",
   "scripts": {

diff --git a/tags.js b/tags.js
@@ -530,7 +530,7 @@ class Tags {
   }
 
   /**
-   * Find if label is already selected
+   * Find if label is already selected (based on attribute)
    * @param {string} text
    * @returns {boolean}
    */
@@ -616,9 +616,9 @@ class Tags {
       });
     }
 
-    // update select
+    // update select, we need to set attribute for isSelected
     if (opt) {
-      opt.selected = true;
+      opt.setAttribute("selected", "selected");
     } else {
       // we need to create a new option
       opt = document.createElement("option");
@@ -628,7 +628,7 @@ class Tags {
       for (const [key, value] of Object.entries(data)) {
         opt.dataset[key] = value;
       }
-      opt.selected = true;
+      opt.setAttribute("selected", "selected");
       this.selectElement.appendChild(opt);
     }