Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added platform option MAC_CATALYST_UNIVERSAL #210

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Added platform option MAC_CATALYST_UNIVERSAL #210

merged 5 commits into from
Jul 19, 2024

Conversation

oliverepper
Copy link
Contributor

I need catalyst on arm64 and x86_64 for a project and added MAC_CATALYST_UNIVERSAL according to MAC_UNIVERSAL.

@oliverepper oliverepper mentioned this pull request Jul 18, 2024
Closed
@leetal
Copy link
Owner

leetal commented Jul 18, 2024 •
edited
Loading

Do you think you could add a new pipeline test-case here for the new MAC_CATALYST_UNIVERSAL variant? it should be a matter of just copying one job description and replace the PLATFORM: MAC_CATALYST for example.

leetal
leetal requested changes Jul 18, 2024
View reviewed changes
Copy link
Owner

@leetal leetal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just add the test and I'll merge this :)

@oliverepper
Copy link
Contributor Author

I added the pipeline test-case.

@leetal leetal merged commit f75a02d into leetal:master Jul 19, 2024
19 checks passed
@leetal
Copy link
Owner

leetal commented Jul 19, 2024

Thanks for adding this! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leetal leetal leetal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverepper @leetal