Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change initialization of electrical load (maint 9.1) #4052

Merged
merged 1 commit into from
Nov 18, 2024
+9 −6
Merged

Change initialization of electrical load (maint 9.1) #4052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Buildings/Electrical/DC/Loads/Resistor.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ The temperature <i>T</i> is the temperature of the heat port if <code>useHeatPor
<li>November 2, 2024, by Michael Wetter:<br/>
Changed guarding against division by zero.<br/>
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4032\">#4032</a>.
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4032\">Buildings #4032</a>.
</li>
<li>November 3, 2015, by Michael Wetter:<br/>
Set default value for <code>P_nominal</code> to avoid an error when translating
Expand Down
9 changes: 8 additions & 1 deletion Buildings/Electrical/Interfaces/Load.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ model Load "Partial model for a generic load"
or linearized)));
parameter Buildings.Electrical.Types.InitMode initMode(
min=Buildings.Electrical.Types.InitMode.zero_current,
max=Buildings.Electrical.Types.InitMode.linearized) = Buildings.Electrical.Types.InitMode.zero_current
max=Buildings.Electrical.Types.InitMode.linearized) = Buildings.Electrical.Types.InitMode.linearized
"Initialization mode for homotopy operator" annotation(Dialog(tab = "Initialization"));

Modelica.Units.SI.Voltage v[:](start=PhaseSystem.phaseVoltages(V_nominal)) =
Expand Down Expand Up @@ -113,6 +113,13 @@ equation
annotation ( Documentation(revisions="<html>
<ul>
<li>
November 14, 2024, by Michael Wetter:<br/>
Changed default initialization method to using linearized model rather than zero current, as
the latter causes a division by zero in OpenModelica during the homotopy initialization.<br/>
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4048\">Buildings, #4048</a>.
</li>
<li>
January 30, 2019, by Michael Wetter:<br/>
Set start value for <code>P</code>.
</li>
Expand Down
4 changes: 0 additions & 4 deletions Buildings/Resources/Scripts/BuildingsPy/conf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
openmodelica:
comment: simulation terminated by an assertion at initialization.
simulate: false
- model_name: Buildings.Electrical.DC.Loads.Examples.LinearizedLoad
openmodelica:
comment: '''omc'' caused ''simulation terminated by an assertion at initialization''.'
simulate: false
- model_name: Buildings.Examples.DualFanDualDuct.ClosedLoop
optimica:
comment: CVode and Radau5ODE hang since https://github.com/lbl-srg/modelica-buildings/pull/3109, likely because Xi rather than mXi is a state
Expand Down
Loading