-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all-electric plant model to DHC package #3263
Conversation
TODO: Refactor MultipleCommands with O conectors for On AND y1Mod
- Rounding at 4 is not enough: use 10 digits for all coefs.
…ssue3188_allElectricPlant
- nChiCoo assumed equal to nChiHea
- Also update release notes
Some documentation and thoughts on why unit tests are failing at 9a94dce. @mwetter I appreciate any thoughts you have when you get a chance:
|
Buildings/Experimental/DHC/Plants/Combined/Controls/BaseClasses/StagingPump.mo
Outdated
Show resolved
Hide resolved
Buildings/Experimental/DHC/Plants/Combined/Controls/BaseClasses/CoolingTowerLoop.mo
Show resolved
Hide resolved
Buildings/Experimental/DHC/Plants/Combined/Controls/BaseClasses/PartialController.mo
Outdated
Show resolved
Hide resolved
Unit tests are failing for:
@mwetter This is unrelated to any changes in the PR as far as I can tell. |
@dhblum Can you improve the time out in conf.yml to 600? |
Huzzah, unit tests pass. |
Buildings/Experimental/DHC/Plants/Combined/Controls/BaseClasses/CoolingTowerLoop.mo
Show resolved
Hide resolved
@mwetter FYI despite my latest commits to address the hysteresis, this PR is not ready to merge anymore. I'm doing some testing to simulate the plant for a fully year and it's not finishing. Need to look into this again. |
@mwetter This morning I tested again the example model which was failing the full simulation before, and after merging latest master, it is now working and simulated the full year ok with dassl and tol 10e-6. I'm not sure what happened before, maybe it was something with my setup at the time. I think I addressed all the hysteresis issues and your comments, so except for confirming unit test pass, let me know if you think there's anything else to be done. I don't have anything in mind. @AntoineGautier might have a review at it as he is back. |
This closes #3188.
Two models fail to compile with OMC, see
.conf.yml
:PartialETS
,PartialBuilding
,PartialBuildingWithPartialETS
,PartialPlant
. The color convention for fluid streams previously used was confusing: for instance CHW return was represented in red color and CHW supply in blue color. The change consists in representing both the CHW return and CHW supply in blue color. In addition, the diagram layer forPartialETS
is expanded as the current model showed a need for more real estate.