Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sistent-box component #6055

Merged

Conversation

mdkaifansari04
Copy link
Contributor

Description
Added sistent box component with detailed documentation and easy examples
This PR fixes #5906

Notes for Reviewers
image
image

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/projects An issue relating to Layer5 initiatives (projects) project/sistent labels Nov 2, 2024
Signed-off-by: Mdkaif-123 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 2, 2024

🚀 Preview for commit bca574a at: https://67269b8315ea81048abdf188--layer5.netlify.app

@vishalvivekm
Copy link
Member

@mdkaifansari04 Let's discuss this on websites call on Monday at 6:30 PM IST (7:00 AM CT). Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented Nov 5, 2024

🚀 Preview for commit 2792c41 at: https://672a88e12362cc512152ddc8--layer5.netlify.app

@Vidit-Kushwaha
Copy link
Contributor

Hello, @mdkaifansari04 , can you remove the excess indentation from the array of code in the code example so that it looks more uniform?

@mdkaifansari04
Copy link
Contributor Author

@Vidit-Kushwaha will make sure fix that and let you know

@mdkaifansari04
Copy link
Contributor Author

@Vidit-Kushwaha can you please check if the changes needs made look perfect

@l5io
Copy link
Contributor

l5io commented Nov 6, 2024

🚀 Preview for commit 2a93ef1 at: https://672bcd526848a14313dd48df--layer5.netlify.app

Copy link

@ianrwhitney ianrwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vidit-Kushwaha
Copy link
Contributor

@mdkaifansari04 It looks great.

@l5io
Copy link
Contributor

l5io commented Nov 11, 2024

🚀 Preview for commit 19b368e at: https://673214f27db18127fcd6e380--layer5.netlify.app

Signed-off-by: Mdkaif-123 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 11, 2024

🚀 Preview for commit 100b21e at: https://673258db5c8bad924148faac--layer5.netlify.app

@sudhanshutech sudhanshutech merged commit 5fb3915 into layer5io:master Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/sistent
Development

Successfully merging this pull request may close these issues.

[Sistent] Add Box component to the sistent components page
7 participants