-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add options, allow passing SMC key #36
base: master
Are you sure you want to change the base?
Conversation
for reference see also https://logi.wiki/index.php/SMC_Sensor_Codes |
unify float/double
Sorry for not replying. I love this idea. I changed master a bit, which I think can help making this easier to do. Wanna try updating it? |
Took a while to get it back to work, but also fixed some issues. Ready for review. Unfortunately, on my M1 Macs this does not produce any useful output anymore :( |
Can we add something like:
at the top or in the /edit I just realized this must have been a breaking API change for political correctness? Yikes… 😬 |
Reasoning:
There is another PR which proposes to change the default keys read for CPU and GPU. This might not fit everybody (does not for me). So I wanted an option to pass the key that works for me.
TCXC
as mentioned in #33 does not work on my older MacBook Pro 2011, butTC0P
orTC0D
orTC0C
work. On a newer MBP 13", theTC0D
does not work. On my work MBP, theTC0D
andTC0C
as well as theTG0P
andTG0D
don't work.To find out what works on a given machine, I added the option to dump all keys.
@lavoiesl : I'm happy to discuss any changes.