Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSS feed #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add RSS feed #10

wants to merge 1 commit into from

Conversation

pronskiy
Copy link

@pronskiy pronskiy commented Oct 4, 2018

This adds an ability to subscribe to events with RSS.
The feed is available at /feed URL path.
Events are sorted by create date not by start date, so that subscriber knows when new events are added.

@ericlbarnes
Copy link
Member

Thanks for this! I hadn't considered adding an RSS feed because I wasn't sure if anyone still used it, but happy to hear there are people that are still using it.

I'd much prefer this if you simplified and removed the 3rd party package requirement. Ideally, you should be able to grab all the future events and just loop them in an RSS blade view. Sort of how I'm grabbing all the events for the JSON API:

https://github.com/laravelnews/laravelevents/blob/master/app/Http/Controllers/HomeController.php#L14-L17

@pronskiy
Copy link
Author

Eric, thanks for the review. I'll remove the dependency and update the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants