Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use Go 1.22 #2588

Merged
merged 2 commits into from
Feb 7, 2024
Merged

CI: Use Go 1.22 #2588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51f321e
CI: Use Go 1.22
aldas Feb 7, 2024
03e7ef6
In Go 1.22 finding name of function with reflection has changed. chan…
aldas Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:

env:
# run static analysis only with the latest Go version
LATEST_GO_VERSION: "1.21"
LATEST_GO_VERSION: "1.22"

jobs:
check:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/echo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:

env:
# run coverage and benchmarks only with the latest Go version
LATEST_GO_VERSION: "1.21"
LATEST_GO_VERSION: "1.22"

jobs:
test:
Expand All @@ -25,7 +25,7 @@ jobs:
# Echo tests with last four major releases (unless there are pressing vulnerabilities)
# As we depend on `golang.org/x/` libraries which only support last 2 Go releases we could have situations when
# we derive from last four major releases promise.
go: ["1.18", "1.19", "1.20", "1.21"]
go: ["1.19", "1.20", "1.21", "1.22"]
name: ${{ matrix.os }} @ Go ${{ matrix.go }}
runs-on: ${{ matrix.os }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions echo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1572,7 +1572,7 @@ func TestEcho_OnAddRouteHandler(t *testing.T) {
})
}

e.GET("/static", NotFoundHandler)
e.GET("/static", dummyHandler)
e.Host("domain.site").GET("/static/*", dummyHandler, func(next HandlerFunc) HandlerFunc {
return func(c Context) error {
return next(c)
Expand All @@ -1582,7 +1582,7 @@ func TestEcho_OnAddRouteHandler(t *testing.T) {
assert.Len(t, added, 2)

assert.Equal(t, "", added[0].host)
assert.Equal(t, Route{Method: http.MethodGet, Path: "/static", Name: "github.com/labstack/echo/v4.glob..func1"}, added[0].route)
assert.Equal(t, Route{Method: http.MethodGet, Path: "/static", Name: "github.com/labstack/echo/v4.TestEcho_OnAddRouteHandler.func1"}, added[0].route)
assert.Len(t, added[0].middleware, 0)

assert.Equal(t, "domain.site", added[1].host)
Expand Down
Loading