Fix/Replaces pluralize with inflector, fails to singularize resource with multiple words #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scopes:
Summary
Given a resource name called "PriceQuiz", an endpoint "/priceQuizzes" was expected, but due to the singularize method of the
pluralize
library, it produces the stringpriceQuizz
instead.Quick test app
Results
Digging into the main issue
According to plurals/pluralize#177, the library produces several inconsistencies across a large number of english words. Several other individual issues might point out that the library fails on a lot more words.
Proposal
Use Inflection (https://github.com/dreamerslab/node.inflection) as an alternative to pluralize.