Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xds): don't merge listeners of headless service instances #9538

Closed

Conversation

jijiechen
Copy link
Member

Should be part of the cause of issue 9006, but may not be complete.

xref: #9006

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • Described
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • Confirmed
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Tested using unit tests and manually
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md?
    • No
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • No, this is new in 2.6.1

@jijiechen jijiechen requested a review from a team as a code owner March 8, 2024 09:01
@jijiechen jijiechen requested review from Automaat, lobkovilya and lukidzi and removed request for a team March 8, 2024 09:01
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a correct fix. You can have multiple tags in outbound in the end. I think we need to compare set of tags in Outbound#Tags

@jakubdyszkiewicz
Copy link
Contributor

Closing for more general fix #9542

@jijiechen jijiechen deleted the vip-listeners-of-headless-services branch March 22, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants