Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kumactl): update 'install demo' to use MeshHTTPRoute #8993

Merged
merged 3 commits into from
Jan 23, 2024
Merged

chore(kumactl): update 'install demo' to use MeshHTTPRoute #8993

merged 3 commits into from
Jan 23, 2024

Conversation

lobkovilya
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lobkovilya lobkovilya requested a review from a team as a code owner January 22, 2024 18:37
@lobkovilya lobkovilya requested review from michaelbeaumont, slonka and lukidzi and removed request for a team January 22, 2024 18:37
slonka
slonka approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but test is failing on https://github.com/kumahq/kuma/actions/runs/7619547758/job/20752807457?pr=8993#step:6:233 - looks like namespace mixup

@bartsmykla bartsmykla enabled auto-merge (squash) January 23, 2024 08:38
@bartsmykla bartsmykla merged commit a7c29d9 into kumahq:master Jan 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla left review comments

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lobkovilya @slonka @bartsmykla