Skip to content

Commit

Permalink
test(e2e): use kumactl get meshes to check on kuma health (#9190)
Browse files Browse the repository at this point in the history
Before we were doing `kumactl get dataplanes`.
but since #9175 this returns 404 when the default mesh doesn't exist.
We have e2e tests where we skip the creation of the default mesh.
We now use just `get meshes` so that this always works

Signed-off-by: Charly Molter <[email protected]>
  • Loading branch information
lahabana authored Feb 9, 2024
1 parent 14dd108 commit ad15912
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions test/framework/k8s_controlplane.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,7 @@ func (c *K8sControlPlane) VerifyKumaCtl() error {
return errors.Errorf("API port not forwarded")
}

output, err := c.kumactl.RunKumactlAndGetOutputV(c.verbose, "get", "dataplanes")
fmt.Println(output)

return err
return c.kumactl.RunKumactl("get", "meshes")
}

func (c *K8sControlPlane) VerifyKumaREST() error {
Expand Down
2 changes: 1 addition & 1 deletion test/framework/universal_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func (c *UniversalCluster) GetKumaCPLogs() (string, error) {
}

func (c *UniversalCluster) VerifyKuma() error {
return c.controlplane.kumactl.RunKumactl("get", "dataplanes")
return c.controlplane.kumactl.RunKumactl("get", "meshes")
}

func (c *UniversalCluster) DeleteKuma() error {
Expand Down

0 comments on commit ad15912

Please sign in to comment.