-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add write permissions for project-infra to release team #3028
Add write permissions for project-infra to release team #3028
Conversation
Signed-off-by: Brian Carey <[email protected]>
Skipping CI for Draft Pull Request. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
This permission can be removed once the release tool is updated to no longer require write access - #3031
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey, xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Makes sense, maybe we can have sig-release and another group who is doing the releases |
Antonio was added to the project-infra OWNERS file[1] in order to get write permissions on project-infra which are required to carry out kubevirt releases. The release team was given write permissions[2] so Antonio no longer needs to be in the OWNERS file. Discussed this with Antonio and he is happy to be removed. [1] kubevirt#3026 [2] kubevirt#3028 Signed-off-by: Brian Carey <[email protected]>
Antonio was added to the project-infra OWNERS file[1] in order to get write permissions on project-infra which are required to carry out kubevirt releases. The release team was given write permissions[2] so Antonio no longer needs to be in the OWNERS file. Discussed this with Antonio and he is happy to be removed. [1] #3026 [2] #3028 Signed-off-by: Brian Carey <[email protected]>
The release team require write permissions for project-infra to create release job configs as part of the kubevirt release.
/cc @acardace @xpivarc