Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write permissions for project-infra to release team #3028

Merged

Conversation

brianmcarey
Copy link
Member

The release team require write permissions for project-infra to create release job configs as part of the kubevirt release.

/cc @acardace @xpivarc

@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Oct 19, 2023
@brianmcarey brianmcarey marked this pull request as ready for review October 19, 2023 09:48
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023
@acardace
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
Copy link
Member Author

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

This permission can be removed once the release tool is updated to no longer require write access - #3031

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey, xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brianmcarey,xpivarc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xpivarc
Copy link
Member

xpivarc commented Oct 19, 2023

Makes sense, maybe we can have sig-release and another group who is doing the releases

@kubevirt-bot kubevirt-bot merged commit 4c18780 into kubevirt:main Oct 19, 2023
4 checks passed
brianmcarey added a commit to brianmcarey/project-infra that referenced this pull request Oct 20, 2023
Antonio was added to the project-infra OWNERS file[1] in order to get write
permissions on project-infra which are required to carry out kubevirt
releases. The release team was given write permissions[2] so Antonio no
longer needs to be in the OWNERS file.

Discussed this with Antonio and he is happy to be removed.

[1] kubevirt#3026
[2] kubevirt#3028

Signed-off-by: Brian Carey <[email protected]>
kubevirt-bot pushed a commit that referenced this pull request Oct 20, 2023
Antonio was added to the project-infra OWNERS file[1] in order to get write
permissions on project-infra which are required to carry out kubevirt
releases. The release team was given write permissions[2] so Antonio no
longer needs to be in the OWNERS file.

Discussed this with Antonio and he is happy to be removed.

[1] #3026
[2] #3028

Signed-off-by: Brian Carey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants