Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IBM Block Storage CSI driver support for RWX #3350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add IBM Block Storage CSI driver support for RWX #3350

wants to merge 1 commit into from

Conversation

kasserater
Copy link

What this PR does / why we need it:
add IBM Block Storage CSI driver support for RWX in the default storage profile. this is required, as upcoming IBM Block Storage CSI driver will add support for RWX. We have several customers that would like to Beta test the upcoming IBM Block Storage CSI driver release, specifically for VM virtualization and live-migration, and we need Openshift to be updated accordingly

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Add RWX to the IBM Block Storage CSI driver default storage profile

Special notes for your reviewer:

Release note:

IBM Block Storage CSI driver now supports RWX access mode

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 21, 2024
@kubevirt-bot
Copy link
Contributor

Hi @kasserater. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 21, 2024
@kasserater
Copy link
Author

/ok-to-test

@kubevirt-bot
Copy link
Contributor

@kasserater: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kasserater
Copy link
Author

/cc @arnongilboa

@kasserater
Copy link
Author

@arnongilboa can you please review this PR? we have multiple customers waiting to Beta test OCP with IBM Block Storage CSI driver with RWX support, specifically for VM Virtualization and live-migration. Successful beta tests can lead to large customer wins for both RH and IBM

@arnongilboa
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2024
@coveralls
Copy link

Coverage Status

coverage: 59.008% (+0.03%) from 58.983%
when pulling 1eb785f on kasserater:main
into 5195176 on kubevirt:main.

@kasserater
Copy link
Author

/retest-required

@kubevirt-bot
Copy link
Contributor

@kasserater: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kasserater
Copy link
Author

@arnongilboa seems like some CI issue in the test. i can't seem to retrigger the tests. can you please assist?
also, how can we make sure this IS NOT merged once all tests are completed? we want to make sure it is released in tandem with the IBM Block Storage CSI driver...
finally, is there a way to bypass the code, for the Beta tests only, so that VMs can utilize live-migration with our IBM Block Storage CSI driver?

@arnongilboa
Copy link
Collaborator

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2024
@arnongilboa
Copy link
Collaborator

@arnongilboa seems like some CI issue in the test. i can't seem to retrigger the tests. can you please assist?

sure, we'll retest once we unhold it

also, how can we make sure this IS NOT merged once all tests are completed? we want to make sure it is released in tandem with the IBM Block Storage CSI driver...

it's on hold until the driver is released

finally, is there a way to bypass the code, for the Beta tests only, so that VMs can utilize live-migration with our IBM Block Storage CSI driver?

you can build based on your own branch for your tests

@awels
Copy link
Member

awels commented Jul 21, 2024

Users can also specify their own spec in the storage profile. That is our escape mechanism for unknown storage drivers. You could write some documentation on how to specify the correct values for your driver.

@awels
Copy link
Member

awels commented Jul 22, 2024

/retest-required

@kasserater
Copy link
Author

thank you @awels . this is what we will recommend our Beta customers and in our official documentation once we GA, until this PR is merged.

@awels
Copy link
Member

awels commented Jul 26, 2024

/approve
feel free to remove the hold whenever you want.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2024
@awels
Copy link
Member

awels commented Oct 24, 2024

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnongilboa arnongilboa arnongilboa approved these changes

@alromeros alromeros Awaiting requested review from alromeros

@ShellyKa13 ShellyKa13 Awaiting requested review from ShellyKa13

Assignees

@arnongilboa arnongilboa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kasserater @kubevirt-bot @arnongilboa @coveralls @awels