Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipam: Reduce git actions noise #1875

Merged
merged 1 commit into from
Aug 21, 2024
Merged

ipam: Reduce git actions noise #1875

merged 1 commit into from
Aug 21, 2024

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Aug 19, 2024

What this PR does / why we need it:
When kubevirt-bot creates PRs, it will trigger the IPAM lane twice, because both
push and pull_request events occur (the bot creates a branch on main, hence push event happens).
The IPAM lane also runs after a PR is merged, because it triggers push.
In order to reduce this noise, lets remove the push event.
The pull_request is enough as long as PRs are used
(and not direct pushes which aren't encouraged, nor monitored anyhow).

Special notes for your reviewer:

Release note:

None

@kubevirt-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 19, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Aug 19, 2024

Opening the PR did trigger it, lets try to push changes

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 19, 2024

pushing changes also worked

we also know that it work for the bot, because the bot had both events triggered
and we removed just one (user uses a fork, hence user doesnt trigger push event, but bot creates branch on main)

P.S atm when the PR is merged, it also triggered a "post submit" due to the push event, so it will stop that from
happening as well (it was not intended to happen)

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 19, 2024

lets check if close open trigger the jobs
note - git actions doesnt rebase, but still important to have it upon reopen
(we can fix the auto rebase later, it isnt related here)

@oshoval oshoval closed this Aug 19, 2024
@oshoval oshoval reopened this Aug 19, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Aug 19, 2024

it triggered upon reopen - we are good in this aspect

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 19, 2024
@oshoval oshoval changed the title WIP: Try to reduce git actions noise WIP: Reduce git actions noise Aug 19, 2024
@oshoval oshoval changed the title WIP: Reduce git actions noise ipam: Reduce git actions noise Aug 19, 2024
When kubevirt-bot creates PRs, it will trigger the IPAM lane twice, because both
`push` and `pull_request` events occur (the bot creates a branch on main,
hence push event happens).
The IPAM lane also runs after a PR is merged, because it triggers `push`.
In order to reduce this noise, lets remove the `push` event.
The `pull_request` is enough as long as PRs are used
(and not direct pushes which aren't encouraged anyhow).

Signed-off-by: Or Shoval <[email protected]>
@oshoval oshoval marked this pull request as ready for review August 19, 2024 14:40
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
Copy link

sonarcloud bot commented Aug 19, 2024

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 21, 2024

/cc @maiqueb @RamLavi

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Aug 21, 2024

Thank you

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@kubevirt-bot kubevirt-bot merged commit 6f00bc0 into kubevirt:main Aug 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants