-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipam: Reduce git actions noise #1875
Conversation
Skipping CI for Draft Pull Request. |
Opening the PR did trigger it, lets try to push changes |
pushing changes also worked we also know that it work for the bot, because the bot had both events triggered P.S atm when the PR is merged, it also triggered a "post submit" due to the push event, so it will stop that from |
lets check if close open trigger the jobs |
it triggered upon reopen - we are good in this aspect |
When kubevirt-bot creates PRs, it will trigger the IPAM lane twice, because both `push` and `pull_request` events occur (the bot creates a branch on main, hence push event happens). The IPAM lane also runs after a PR is merged, because it triggers `push`. In order to reduce this noise, lets remove the `push` event. The `pull_request` is enough as long as PRs are used (and not direct pushes which aren't encouraged anyhow). Signed-off-by: Or Shoval <[email protected]>
Quality Gate passedIssues Measures |
Thank you /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
When kubevirt-bot creates PRs, it will trigger the IPAM lane twice, because both
push
andpull_request
events occur (the bot creates a branch on main, hencepush
event happens).The IPAM lane also runs after a PR is merged, because it triggers
push
.In order to reduce this noise, lets remove the
push
event.The
pull_request
is enough as long as PRs are used(and not direct pushes which aren't encouraged, nor monitored anyhow).
Special notes for your reviewer:
Release note: