Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git actions, ipam: Run on all branches #1867

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Aug 15, 2024

What this PR does / why we need it:
This way we won't need to change the manifests when branching.

Special notes for your reviewer:

Release note:

None

This way we won't need to change the manifests when branching.

Signed-off-by: Or Shoval <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 15, 2024
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 15, 2024
Copy link

sonarcloud bot commented Aug 15, 2024

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 15, 2024

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator

@oshoval: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@oshoval oshoval added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@kubevirt-bot kubevirt-bot merged commit b129bb3 into kubevirt:main Aug 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants