Merge pull request #19724 from prezha/autoupdate-kube-vip

HA (multi-control plane): Automate kube-vip version update

.github/workflows/update-kube-vip-version.yml

@@ -0,0 +1,48 @@
+name: "update-kube-vip-version"
+on:
+  workflow_dispatch:
+  schedule:
+    # every Monday at around 3 am pacific/10 am UTC
+    - cron: "0 10 * * 1"
+env:
+  GOPROXY: https://proxy.golang.org
+  GO_VERSION: '1.23.0'
+permissions:
+  contents: read
+
+jobs:
+  bump-kube-vip-version:
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+      - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32
+        with:
+          go-version: ${{env.GO_VERSION}}
+      - name: Bump kube-vip version
+        id: bumpKubeVip
+        run: |
+          echo "OLD_VERSION=$(DEP=kube-vip make get-dependency-version)" >> "$GITHUB_OUTPUT"
+          make update-kube-vip-version
+          echo "NEW_VERSION=$(DEP=kube-vip make get-dependency-version)" >> "$GITHUB_OUTPUT"
+          # The following is to support multiline with GITHUB_OUTPUT, see https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings
+          echo "changes<<EOF" >> "$GITHUB_OUTPUT"
+          echo "$(git status --porcelain)" >> "$GITHUB_OUTPUT"
+          echo "EOF" >> "$GITHUB_OUTPUT"
+      - name: Create PR
+        if: ${{ steps.bumpKubeVip.outputs.changes != '' }}
+        uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f
+        with:
+          token: ${{ secrets.MINIKUBE_BOT_PAT }}
+          commit-message: 'HA (multi-control plane): Update kube-vip from ${{ steps.bumpKubeVip.outputs.OLD_VERSION }} to ${{ steps.bumpKubeVip.outputs.NEW_VERSION }}'
+          committer: minikube-bot <[email protected]>
+          author: minikube-bot <[email protected]>
+          branch: auto_bump_kube_vip_version
+          push-to-fork: minikube-bot/minikube
+          base: master
+          delete-branch: true
+          title: 'HA (multi-control plane): Update kube-vip from ${{ steps.bumpKubeVip.outputs.OLD_VERSION }} to ${{ steps.bumpKubeVip.outputs.NEW_VERSION }}'
+          labels: ok-to-test
+          body: |
+            The kube-vip project released a [new version](https://github.com/kube-vip/kube-vip)
+
+            This PR was auto-generated by `make update-kube-vip-version` using [update-kube-vip-version.yml](https://github.com/kubernetes/minikube/tree/master/.github/workflows/update-kube-vip-version.yml) CI Workflow.

Makefile

@@ -1255,3 +1255,8 @@ get-dependency-version:
 .PHONY: generate-licenses
 generate-licenses:
 	./hack/generate_licenses.sh
+
+.PHONY: update-kube-vip-version
+update-kube-vip-version:
+	(cd hack/update/kube_vip_version && \
+	 go run update_kube_vip_version.go)

hack/update/get_version/get_version.go

@@ -60,6 +60,7 @@ var dependencies = map[string]dependency{
 	"istio-operator":          {addonsFile, `istio/operator:(.*)@`},
 	"kindnetd":                {"pkg/minikube/bootstrapper/images/images.go", `kindnetd:(.*)"`},
 	"kong":                    {addonsFile, `kong:(.*)@`},
+	"kube-vip":                {"pkg/minikube/cluster/ha/kube-vip/kube-vip.go", `image: ghcr.io/kube-vip/kube-vip:(.*)`},
 	"volcano":                 {addonsFile, `volcanosh/vc-webhook-manager:(.*)@`},
 	"kong-ingress-controller": {addonsFile, `kong/kubernetes-ingress-controller:(.*)@`},
 	"kubectl":                 {addonsFile, `bitnami/kubectl:(.*)@`},

hack/update/kube_vip_version/update_kube_vip_version.go

@@ -0,0 +1,62 @@
+/*
+Copyright 2024 The Kubernetes Authors All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package main
+
+import (
+	"context"
+	"time"
+
+	"k8s.io/klog/v2"
+
+	"k8s.io/minikube/hack/update"
+)
+
+const (
+	// default context timeout
+	cxTimeout = 5 * time.Minute
+)
+
+var (
+	schema = map[string]update.Item{
+		"pkg/minikube/cluster/ha/kube-vip/kube-vip.go": {
+			Replace: map[string]string{
+				`image: ghcr.io/kube-vip/kube-vip:.*`: `image: ghcr.io/kube-vip/kube-vip:{{.StableVersion}}`,
+			},
+		},
+	}
+)
+
+// Data holds stable kube-vip version in semver format.
+type Data struct {
+	StableVersion string
+}
+
+func main() {
+	// set a context with defined timeout
+	ctx, cancel := context.WithTimeout(context.Background(), cxTimeout)
+	defer cancel()
+
+	// get kube-vip stable version
+	stable, err := update.StableVersion(ctx, "kube-vip", "kube-vip")
+	if err != nil {
+		klog.Fatalf("Unable to get kube-vip stable version: %v", err)
+	}
+	data := Data{StableVersion: stable}
+	klog.Infof("kube-vip stable version: %s", stable)
+
+	update.Apply(schema, data)
+}

pkg/minikube/cluster/ha/kube-vip/kube-vip.go

@@ -32,8 +32,8 @@ import (
 const Manifest = "kube-vip.yaml"
 
 // KubeVipTemplate is kube-vip static pod config template
-// ref: https://kube-vip.io/docs/installation/static/
-// update: regenerate with:
+// ref: https://kube-vip.io/docs/installation/static/#generating-a-manifest
+// note: to check if the latest kube-vip version introduces any significant changes, compare the current one with a latest default manifest generated with:
 //
 //	export KVVERSION=$(curl -sL https://api.github.com/repos/kube-vip/kube-vip/releases | jq -r ".[0].name")
 //	docker run --rm ghcr.io/kube-vip/kube-vip:$KVVERSION manifest pod --interface eth0 --address 192.168.42.17 --controlplane --arp --leaderElection