-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terraform for Azure community image gallery #7461
base: main
Are you sure you want to change the base?
Conversation
/cc @jsturtevant @nojnhuh @ritikaguptams I'm not entirely sure what I'm doing here, so I used the |
/hold for reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
resource_group_name = "cluster-api-gallery" | ||
tags = { | ||
creationTimestamp = "2024-10-24T00:00:00Z" | ||
jobName = "image-builder-sig-ubuntu-2404" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this tag meaningful? Seems odd to have one for a specific image build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it really isn't informative. I think we just propagate the same ${TAGS}
to several resources, and that job is the one that lazily created the gallery. I'll delete it after I wait to see if there's more feedback on this PR.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Adds terraform needed to recreate the basic Azure community gallery resources used to host Cluster API Provider for Azure reference images.
The managed images, SIG image versions, SIG image definitions, and staging gallery are all transient and fungible resources that will be recreated if needed by the publishing pipeline, so they do not have to be handled by terraform.
See also: