Instance Group Manager does not remove nodes with empty string in the zone field #2658
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @08volt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
/lgtm |
|
/hold |
k8s-ci-robot
added
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
my lgtm was accidental, for now |
k8s-ci-robot
removed
the
lgtm
08volt
force-pushed
the
empty-zones
branch
3 times, most recently
from
1f151d8
to
726a46f
Compare
08volt
force-pushed
the
empty-zones
branch
2 times, most recently
from
fb05798
to
0b2fcc6
Compare
08volt
force-pushed
the
empty-zones
branch
3 times, most recently
from
012b702
to
5a6b7ee
Compare
Nodes can have empty zone if it not has been assigned yet. The zone was retrieved from providerID using the following Regular Expression Matching and taking the second match: ```var providerIDRE = regexp.MustCompile(`^` + "gce" + `://([^/]+)/([^/]+)/([^/]+)$`)``` In the case of empty zone it was generating an Error. In order to allow an empty zone to match the Regular Expression, it has been updated to: ```var providerIDRE = regexp.MustCompile(`^` + "gce" + `://([^/]+)/([^/]*)/([^/]+)$`)``` After that, I updated all the instances where the code was checking the error, to check also for the empty zone. I updated the Instance Group Manager to not remove the nodes which do not have a zone assigned.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 08volt, cezarygerard, mmamczur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@08volt: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
Updates Instance Group Manager to Support Nodes with Empty Zones
Bug:
The Load Balancer controller removes nodes with an empty string in the Zone field, even when they are already in the correct instance group.
Solution:
Prevents the removal of nodes with an empty string in the Zone field.
Details:
providerIDusing a regular expression (var providerIDRE = regexp.MustCompile(^+ "gce" +://([^/]+)/([^/]+)/([^/]+)$)) that didn't account for empty Zones, leading to errors.var providerIDRE = regexp.MustCompile(^+ "gce" +://([^/]+)/([^/]*)/([^/]+)$)to support empty Zones.