[WIP] Manage a specified portion of resources #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/api-change
k8s-ci-robot
added
the
size/XXL
✅ Deploy Preview for k8s-kwok canceled.
|
wzshiming
force-pushed
the
feat/flag-manage
branch
8 times, most recently
from
bf7e65d
to
4726c33
Compare
wzshiming
force-pushed
the
feat/flag-manage
branch
from
2afd06e
to
4726c33
Compare
wzshiming
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
wzshiming
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
wzshiming
force-pushed
the
feat/flag-manage
branch
3 times, most recently
from
7027e3b
to
5ba035d
Compare
wzshiming
force-pushed
the
feat/flag-manage
branch
from
5ba035d
to
8c9bd26
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref #1122
Special notes for your reviewer:
Compatibility with existing flags and configurations
This allows you to specify resources to manage, not just nodes.
Use
--manage Node:metadata.name=<nodename>instead of--manage-single-node <nodename>.Use
--manage Nodeinstead of--manage-all-nodes.Use
--manage Node:metadata.annotations.<key>=<value>instead of--manage-nodes-with-annotation-selector <key>=<value>.Use
--manage Node:metadata.labels.<key>=<value>instead of--manage-nodes-with-label-selector <key>=<value>.and have the same configuration change
[BROKEN] Use
--managewill no longer manage all resources with Stages by default; it will only manage specified resources.Examples
Use
--manage VirtualMachineInstance.kubevirt.io/v1to specified https://github.com/kubevirt/kubevirtci/blob/4cc10185aca83b7d884183ecf6ff7dfc040f23fc/cluster-provision/k8s/1.31/manifests/kwok/kubevirt/stage/vmi-ready.yamlDoes this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: