Merge pull request #1208 from wzshiming/ci/lint

Add lint for non-linux
kubernetes-sigs · Sep 2, 2024 · f840dce · f840dce
2 parents ba2e4c8 + 5a5309d
commit f840dce
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/golangci-lint.yaml b/.github/workflows/golangci-lint.yaml
@@ -12,7 +12,14 @@ env:
 jobs:
   golangci:
     name: lint
-    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    strategy:
+      matrix:
+        os:
+        - ubuntu-latest
+        - macos-latest
+        - windows-latest
+    runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/setup-go@v5
       with:
@@ -22,4 +29,4 @@ jobs:
       uses: golangci/golangci-lint-action@v6
       with:
         version: v${{ env.GOLANGCI_VERSION }}
-        args: --timeout=30m --config=.golangci.yaml
+        args: --timeout=8m --config=.golangci.yaml --new --fix
diff --git a/pkg/utils/path/path_windows.go b/pkg/utils/path/path_windows.go
@@ -26,5 +26,5 @@ import (
 // Clean is a wrapper around filepath.Clean that converts all path separators to
 // forward slashes. This is useful for Windows paths that are used in URLs.
 func Clean(p string) string {
-	return strings.Replace(filepath.Clean(p), `\`, `/`, -1)
+	return strings.ReplaceAll(filepath.Clean(p), `\`, `/`)
 }