Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add myself as reviewer and approver #507

Merged
merged 1 commit into from
Aug 11, 2023
Merged

add myself as reviewer and approver #507

merged 1 commit into from
Aug 11, 2023

Conversation

ipochi
Copy link
Contributor

@ipochi ipochi commented Jul 27, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ipochi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2023
cheftako
cheftako reviewed Jul 28, 2023
View reviewed changes
OWNERS
@@ -4,10 +4,12 @@ reviewers:
- dberkov
- jefftree
- tallclair
- ipochi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully in support of adding you as a reviewer.

cheftako
cheftako reviewed Jul 28, 2023
View reviewed changes
OWNERS Outdated
approvers:
- anfernee
- cheftako
- jkh52
- ipochi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K/K policy is that approvers have to have first spent 3 months (a release) as a reviewer before becoming an approver.

@ipochi ipochi force-pushed the imran/add-myself-as-reviewer branch from 489ed59 to e768055 Compare July 31, 2023 07:16
@jkh52
Copy link
Contributor

jkh52 commented Aug 4, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@cheftako
Copy link
Contributor

cheftako commented Aug 4, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, ipochi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@jkh52
Copy link
Contributor

jkh52 commented Aug 4, 2023

/verify-owners

@jkh52
Copy link
Contributor

jkh52 commented Aug 4, 2023

@ipochi looks like you need to join Kubernetes membership to become a reviewer. One of us can be your sponsor, if you would like.

@ipochi ipochi mentioned this pull request Aug 4, 2023
Closed
9 tasks
@ipochi
Copy link
Contributor Author

ipochi commented Aug 4, 2023

@ipochi looks like you need to join Kubernetes membership to become a reviewer. One of us can be your sponsor, if you would like.

Created a PR for the same
kubernetes/org#4368

@ipochi
Copy link
Contributor Author

ipochi commented Aug 11, 2023

@ipochi looks like you need to join Kubernetes membership to become a reviewer. One of us can be your sponsor, if you would like.

Created a PR for the same kubernetes/org#4368

PR merged 🥳

@ipochi
Copy link
Contributor Author

ipochi commented Aug 11, 2023

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 87a6b6b into kubernetes-sigs:master Aug 11, 2023
@ipochi ipochi deleted the imran/add-myself-as-reviewer branch August 11, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@dberkov dberkov Awaiting requested review from dberkov

@Jefftree Jefftree Awaiting requested review from Jefftree

Assignees

@jkh52 jkh52

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ipochi @k8s-ci-robot @jkh52 @cheftako