-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bunch of -Wall
warnings
#592
fix a bunch of -Wall
warnings
#592
Conversation
d6d3c2a
to
05461d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging @NiLuJe for qimagescale.cpp quick review.
Fix `parse_integer`'s prototype: the function actually parses an unsigned integer.
05461d6
to
37f7ef6
Compare
CI suceeded on master after this is merged, even though part 2 was not yet merged. |
It's probably intentional until that is merged so the warnings can be turned on without being distracting noise. |
The thinking was more along the lines of: suppress spurious warnings, and rely on annotations. I need to check how multi-line matchers work, see if we can get all the details of a warning (e.g. the following reasoning notes by clang-tidy) in the annotation. |
Note: there's also the summary in the workflow. |
Rehash of #579, only the uncontroversial stuff, with amended commit messages.
This change is