+Add support for multiple sections #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including documentation update Fix konstantinmuenster#21
diiigle
force-pushed
the
multiple_sections
branch
from
bd66e20
to
9b7af82
Compare
including documentation update Fix konstantinmuenster#21
including documentation update Fix konstantinmuenster#21
including documentation update Fix konstantinmuenster#21
including documentation update Fix konstantinmuenster#21
diiigle
force-pushed
the
multiple_sections
branch
from
9b7af82
to
52eb293
Compare
There was a problem hiding this comment.
Thanks a lot @diiigle – really appreciated! I left a comment. Would be great if we can improve this before merging 👍
Comment on lines
+11
to
+16
| const allFiles = response.allFile.aboutFiles; | ||
| const fileNameNeedle = props.fileName ? props.fileName : 'about'; | ||
| const result = allFiles.find((file) => { | ||
| return file.name == fileNameNeedle; | ||
| }); | ||
| const section = result ? result.section[0] : allFiles[0].section[0]; |
There was a problem hiding this comment.
Would be great if we could abstract this away + add null checking and error messages for unknown sections. For example, for the Legal sections, we did:
const data = getSectionBySectionId(response, props.sectionId);and handled the data part entirely in Legal/data.tsx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #21
Started with
Projectsand will port the same mechanism to the other sections as well. But feel free to give some feedback already, especially on the typescript best practices (got virtually 0 experience there)!Summary
It queries for
Filenodes instead of specific*Jsonnodes now, and filters inside the component. Not ideal (the filtering could happen in graphql already), but that its the only way possible with staticQueries (and without variables).Updated the documentation to the best of my knowledge. The example content could be a lot more creative.
Progress
Legalalready contains a filtering mechanism