Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support gnome 45 #224

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

support gnome 45 #224

wants to merge 3 commits into from

Conversation

DisDis
Copy link

@DisDis DisDis commented Oct 1, 2023

  • Removed support below version 45(Gnome), because Gnome45 Extension migrated to ESM.
  • Created separated files Logger.js, convenience.js, prefs.js to GJS and ESM versions.

@DisDis
Copy link
Author

DisDis commented Oct 1, 2023

This MR fix #223

@thekswenson
Copy link

thekswenson commented Oct 18, 2023

Thanks for your work!

I'm running this version of the code on my machine. Things seem to working the way I had them set up. Something is different though:

  • if I click on the icon it does not open the cpufreq window
  • when I open the CPUFreq manager GUI via the gnome .desktop icon, it will change my current power profile.

@DisDis
Copy link
Author

DisDis commented Oct 18, 2023

I found issue, it is "Splash Screen"

@DisDis
Copy link
Author

DisDis commented Oct 18, 2023

@thekswenson I fix it. Please check it.

@xiaklizrum
Copy link

@DisDis hello!

I install extension with your fixes and have some issues:

After install some files dont copy to extension folder:

Unable to load file from: file:///usr/local/share/gnome-shell/extensions/cpufreq@konkor/common/Logger.esm.js (Error opening file /usr/local/share/gnome-shell/extensions/cpufreq@konkor/common/Logger.esm.js: No such file or directory)

Unable to load file from: file:///usr/local/share/gnome-shell/extensions/cpufreq@konkor/convenience.esm.js (Error opening file /usr/local/share/gnome-shell/extensions/cpufreq@konkor/convenience.esm.js: No such file or directory)

When I copy these files extension available to run, but I cant forward to settings:

  • from Gnome's "Extensions" settings button raise error windows with message:
Error: gettext can only be called from extensions

Stack trace:
  #lookupExtension@resource:///org/gnome/Shell/Extensions/js/extensions/sharedInternals.js:219:19
  #gettext@resource:///org/gnome/Shell/Extensions/js/extensions/sharedInternals.js:224:48
  @file:///usr/local/share/gnome-shell/extensions/cpufreq@konkor/prefs.js:65:9
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
  • from extension settings when I click on "gear" icon nothing happens

OS: ArchLinux
gnome-shell: 1:45.0+r17+gebf2f8036-1

@thekswenson
Copy link

@thekswenson I fix it. Please check it.

Works for me!

@websitek
Copy link

websitek commented Nov 4, 2023

any idea when it will be ready ?

@aisivan36
Copy link

I have this error when compiling on Ubuntu 23.10 it says: configure: error: glib-compile-schemas not found.
I am happy if anyone is willing to compile from the source.

@luisalvarado
Copy link

I think I read the original creator stopped and moved to Windows or something to that effect, so instead of a PR you would need a new branch that also creates a new https://extensions.gnome.org/extension/1082/cpufreq/ because if that message is true, sadly this powerful extension is dead.

@nater1983
Copy link

image

still having this issue with gettext

@nater1983
Copy link

and @DisDis will you be porting this to Shell 46 ????

@nater1983
Copy link

The extension runs great just trying to access settings from the Extensions program is not working and producing that error

@gilvbp
Copy link

gilvbp commented Mar 23, 2024

and @DisDis will you be porting this to Shell 46 ????

check this MR: DisDis#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants