refactor(HACBS-2381): refactor main file #215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operator-toolkit has been already released and operator-goodies is deprecated. Signed-off-by: David Moreno García <[email protected]>
This change is focused on webhooks. It increases consistency and follow operator-toolkit best practices. Signed-off-by: David Moreno García <[email protected]>
This change is focused on controllers. It increases consistency and follow operator-toolkit best practices. Signed-off-by: David Moreno García <[email protected]>
This change is focused on the syncer. It increases consistency and follow operator-toolkit best practices. Signed-off-by: David Moreno García <[email protected]>
This change is focused on the loader. It increases consistency and follow operator-toolkit best practices. Signed-off-by: David Moreno García <[email protected]>
Signed-off-by: David Moreno García <[email protected]>
The refactor is focused on extracting the logic into smaller functions. Signed-off-by: David Moreno García <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 85.66% 85.61% -0.06%
==========================================
Files 24 23 -1
Lines 1479 1453 -26
==========================================
- Hits 1267 1244 -23
+ Misses 152 150 -2
+ Partials 60 59 -1
☔ View full report in Codecov by Sentry. |
|
This depends on #214 and also includes all of its changes. Given that, I am not really sure how this is ready for review |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor is focused on extracting the logic into smaller functions.
Depends on #214