Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding error boundary above App #475

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+28 −7
Open

Adding error boundary above App #475

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd61d4e
Adding error boundary above App
Tamir198 Oct 1, 2023
ff982e5
Adding error boundary fallback component
Tamir198 Oct 3, 2023
6a19d36
Update yarn lock file
Tamir198 Oct 3, 2023
dbd8175
Change error boundary message format
Tamir198 Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions frontend/src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ import React from "react";
import ReactDOM from "react-dom/client";
import App from "./App";
import "./index.css";
import { ErrorBoundary } from "react-error-boundary";

ReactDOM.createRoot(document.getElementById("root") as HTMLElement).render(
<React.StrictMode>
<App />
</React.StrictMode>
<ErrorBoundary fallback={<div>Something went wrong</div>}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing "Something went wrong" is not enough. We should display some error details, as well as suggestion to reload the page or start from the root of the application.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to nir regarding what more to do in this pr, I will have an update later this week

<React.StrictMode>
<App />
</React.StrictMode>
</ErrorBoundary>
);
Loading
Loading