Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing checks #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add missing checks #196

wants to merge 2 commits into from

Conversation

yasahi-hpc
Copy link
Collaborator

This PR aims at adding missing checks.

  • Add extents consistency check for all-extents. Previously, we checked only for the transform axis of R2C and C2R transforms.
  • Disallow to use inplace Plan on out-of-place Views (plan is not identical)
  • Add throw tests for these cases

@yasahi-hpc yasahi-hpc self-assigned this Nov 5, 2024
@yasahi-hpc yasahi-hpc added enhancement New feature or request cleanup labels Nov 5, 2024
@tpadioleau tpadioleau self-requested a review November 6, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau Awaiting requested review from tpadioleau

At least 1 approving review is required to merge this pull request.

Assignees

@yasahi-hpc yasahi-hpc

Labels
cleanup enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yasahi-hpc