Adding conda info for libraries, polishing #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
reviewed
Oct 19, 2023
| - furo | ||
| - myst-parser | ||
| - sphinx-copybutton | ||
| - m2r2 |
There was a problem hiding this comment.
i think all this above is superfluous, and we are just duplicating what is writte in the build_requirements.txt.
There was a problem hiding this comment.
Agreed, please refer to the requirement file and do not duplicate content. This would inevitably go out of date.
There was a problem hiding this comment.
OK. I'll. close this PR
fnrizzi
reviewed
Oct 19, 2023
|
|
||
| Each of the above libraries can be installed using `conda` or `pip`. | ||
|
|
||
| These libraries are needed for local documentation rendering, a critical check *before* creating pull requests (PR), and updating existing PR. |
There was a problem hiding this comment.
please remove this sentence, I don't think it adds much. We are already saying what the requirements are, the word says it all :)
|
Consensus: does. not add substantively to the "getting started" process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to add info about using the Anaconda implementation of Python for Kokkos documentation work. It attempts to distinguish conda and pip resources, where necessary, and adds touches of polish here and there.