Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Damien L-G <[email protected]>
  • Loading branch information
masterleinad and dalg24 authored Nov 6, 2024
1 parent 6cd5bc7 commit cfb0c31
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions docs/source/API/core/KokkosConcepts.rst
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,7 @@ and ``OpenMPTarget``, the current state of the Kokkos |ExecutionSpaceTwo|_ conce
template <typename Ex>
concept ExecutionSpace =
Regular<Ex> &&
Destructible<Ex> &&
std::regular<Ex> &&
// Member type requirements:
requires() {
typename Ex::execution_space;
Expand Down
2 changes: 1 addition & 1 deletion docs/source/API/core/execution_spaces.rst
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ and an instance of that type ``ex``, Kokkos guarantees the following expressions
ex.fence(str);
*Effects:* Upon return, all parallel patterns executed on the instance ``ex`` are guaranteed to have completed, and their effects are guaranteed visible to the calling thread. The optiopnal ``str`` argument allows customizing the event reported to Kokkos Tools.
*Effects:* Upon return, all parallel patterns and deep_copy calls executed on the instance ``ex`` are guaranteed to have completed, and their effects are guaranteed visible to the calling thread. The optiopnal ``str`` argument allows customizing the event reported to Kokkos Tools.
*Returns:* Nothing.
*Note:* This *cannot* be called from within a parallel pattern. Doing so will lead to unspecified effects (i.e., it might work, but only for some execution spaces, so be extra careful not to do it).

Expand Down

0 comments on commit cfb0c31

Please sign in to comment.