-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cleanup Prow job and setup alert #3222
Conversation
This is not needed. We already authenticate to gcr.io test-infra/images/prow-tests/Dockerfile Line 242 in 23df246
Unless we are logging in to other registries. |
14f666d
to
577be5b
Compare
I did some more tests, and have confirmed we need two changes together to make it working:
I'm not entirely sure about the reason, but I have tested it at https://prow.knative.dev/view/gs/knative-prow/logs/ci-knative-cleanup-chizhg-test/1509776600835559424 and it's working. I have updated the PR description as well. |
@upodroid can I get an LGTM if this looks good to you? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, large diff though
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chizhg, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, mostly vendor/ updates though. There are some discussions in knative/infra#134 about it. |
@chizhg: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github.com/google/go-containerregistry
needs to be updated to the latest version. It's now using a very old one.gcloud auth configure-docker
command is needed for running thecleanup
toolcleanup
Prow job to send alerts to Slack if it fails/cc @upodroid @kvmware