-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the scorecard github action and its badge #15473
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: harshitasao <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harshitasao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @harshitasao! It looks like this is your first PR to knative/serving 🎉 |
Hi @harshitasao. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc @davidhadas |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15473 +/- ##
==========================================
+ Coverage 84.44% 84.46% +0.02%
==========================================
Files 219 219
Lines 13608 13608
==========================================
+ Hits 11491 11494 +3
+ Misses 1744 1743 -1
+ Partials 373 371 -2 ☔ View full report in Codecov by Sentry. |
/ok-to-test |
@davidhadas gentle ping |
I suggest we separate this PR into 2 parts: First, lets add the Scorecard GitHub Action << I am ok with the suggested changed to .github Then, lets resolve all pending issues with the Scorecard such as those indicated in #15474 Last, when the community is ok with the Scorecard, we can add the comment and badge to the community readme file. I therefore suggest to remove the changes to the readme (and badge) from this PR and add it in a future PR when the Scorecard is community approved. |
Fixes knative/community#1592
Proposed Changes
PR to add the Scorecard GitHub Action and its badge in the README file.
Release Note