-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove duplicated observedGeneration from jobsinks.sinks.knative.dev #8326
fix: remove duplicated observedGeneration from jobsinks.sinks.knative.dev #8326
Conversation
The committers listed above are authorized under a signed CLA. |
Hi @Fabian-K. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for the PR @Fabian-K /ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8326 +/- ##
=======================================
Coverage 64.58% 64.58%
=======================================
Files 373 373
Lines 22619 22619
=======================================
Hits 14609 14609
Misses 7244 7244
Partials 766 766 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fabian-K, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR removes the duplicated observedGeneration in jobsinks.sinks.knative.dev. This was intoduced in #8297
Proposed Changes
Pre-review Checklist