Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broker transformation test to upgrade tests #8190

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Sep 12, 2024

Proposed Changes

  • Refactor broker transformation test so that it can be used in upgrade tests (this will also be reused in knative-extensions/eventing-kafka-broker, see WIP pull request )
  • Include Broker transformation test in upgrade test suite
  • Fix DurableFeature. The FeatureF must be a function that can be called multiple times on demand, and it will create a new feature every time - with different resources to prevent clash with existing resources.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (c91a9d8) to head (5928540).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8190   +/-   ##
=======================================
  Coverage   67.45%   67.45%           
=======================================
  Files         371      371           
  Lines       18039    18039           
=======================================
  Hits        12169    12169           
  Misses       5091     5091           
  Partials      779      779           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgencur mgencur changed the title [WIP] Add broker transformation test to upgrade tests Add broker transformation test to upgrade tests Sep 12, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@mgencur
Copy link
Contributor Author

mgencur commented Sep 13, 2024

/test unit-tests

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
Copy link

knative-prow bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@knative-prow knative-prow bot merged commit 608e76c into knative:main Sep 16, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants