Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthZ: Provide function to update AppliedEventPoliciesStatus based on a given list of applying policies #8173

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 20, 2024

Add another function to auth package to allow updating a resources AppliedEventPoliciesStatus based on a given list of applying policies.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2024
Copy link

knative-prow bot commented Aug 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.38%. Comparing base (bf945f9) to head (40c4c80).
Report is 9 commits behind head on main.

Files Patch % Lines
pkg/auth/event_policy.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #8173       +/-   ##
=========================================
+ Coverage      0   67.38%   +67.38%     
=========================================
  Files         0      371      +371     
  Lines         0    18191    +18191     
=========================================
+ Hits          0    12258    +12258     
- Misses        0     5152     +5152     
- Partials      0      781      +781     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr closed this Aug 20, 2024
@creydr creydr reopened this Aug 27, 2024
@creydr creydr marked this pull request as ready for review August 27, 2024 08:07
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@knative-prow knative-prow bot requested a review from matzew August 27, 2024 08:07
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
Copy link

knative-prow bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ecae895 into knative:main Aug 27, 2024
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants