-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] 🧹 Removing the vendor dir #8054
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
go.mod
Outdated
@@ -50,6 +50,8 @@ require ( | |||
sigs.k8s.io/yaml v1.4.0 | |||
) | |||
|
|||
replace knative.dev/hack => github.com/cardil/knative-hack v0.0.0-20240627155243-4b5dad135546 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Don't merge with this replace
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8054 +/- ##
=======================================
Coverage 67.87% 67.87%
=======================================
Files 368 368
Lines 17551 17551
=======================================
Hits 11912 11912
Misses 4894 4894
Partials 745 745 ☔ View full report in Codecov by Sentry. |
dff4435
to
b89a4a7
Compare
/test all |
/override "Code Style / style / Golang / Lint" |
@cardil: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "style / Golang / Lint" The lint reports files outside of the change context: https://github.com/knative/eventing/actions/runs/9759383289/job/26938506393?pr=8054 |
@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/override "style / Golang / Lint" The Golang-lint reports files outside the change context, because of a large PR:
See: https://github.com/knative/eventing/actions/runs/9861887873/job/27231331728?pr=8054 |
@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "style / Golang / Lint" Ref.: |
@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
@cardil: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This Pull Request is stale because it has been open for 90 days with |
Tests knative/hack#386
Proposed Changes