feat: reduced unnecessary creation of filters (#8118)

Signed-off-by: Calum Murray <[email protected]>
knative · Aug 14, 2024 · 1123cfa · 1123cfa
1 parent 71d5d5f
commit 1123cfa
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/pkg/eventfilter/subscriptionsapi/all_filter.go b/pkg/eventfilter/subscriptionsapi/all_filter.go
@@ -42,6 +42,11 @@ type allFilter struct {
 
 // NewAllFilter returns an event filter which passes if all the contained filters pass
 func NewAllFilter(filters ...eventfilter.Filter) eventfilter.Filter {
+	// just one filter, no need to create a new AllFilter
+	if len(filters) == 1 {
+		return filters[0]
+	}
+
 	filterCounts := make([]filterCount, len(filters))
 	for i, filter := range filters {
 		filterCounts[i] = filterCount{

diff --git a/pkg/eventfilter/subscriptionsapi/any_filter.go b/pkg/eventfilter/subscriptionsapi/any_filter.go
@@ -37,6 +37,11 @@ type anyFilter struct {
 
 // NewAnyFilter returns an event filter which passes if any of the contained filters passes.
 func NewAnyFilter(filters ...eventfilter.Filter) eventfilter.Filter {
+	// just one filter, no need to create a new AnyFilter
+	if len(filters) == 1 {
+		return filters[0]
+	}
+
 	filterCounts := make([]filterCount, len(filters))
 	for i, filter := range filters {
 		filterCounts[i] = filterCount{