Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default Ko version #708

Merged

Conversation

pierDipi
Copy link
Member

It's been reported here as a bug knative/eventing#7799 (comment)

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested review from krsna-m and upodroid April 23, 2024 08:22
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@pierDipi
Copy link
Member Author

/cc @creydr @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 April 23, 2024 08:22
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2024
@knative-prow knative-prow bot requested a review from creydr April 23, 2024 08:22
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

knative-prow bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@knative-prow knative-prow bot merged commit 7b147fc into knative-extensions:main Apr 23, 2024
24 of 26 checks passed
@pierDipi pierDipi deleted the bump-default-ko-version branch April 23, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants