Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTPS in StartSenderToResource #559

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Support HTTPS in StartSenderToResource #559

merged 1 commit into from
Jul 31, 2023

Conversation

pierDipi
Copy link
Member

This will allow reusing tests that use StartSenderToResource with strict transport-encryption.

@pierDipi
Support HTTPS in StartSenderToResource
458f791 
This will allow reusing tests that use `StartSenderToResource` with
strict transport-encryption.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@knative-prow knative-prow bot requested review from cardil and upodroid July 31, 2023 08:31
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2023
@pierDipi
Copy link
Member Author

/cherry-pick release-1.10

@knative-prow-robot
Copy link

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member Author

pierDipi commented Jul 31, 2023 •
edited
Loading

/cherry-pick release-1.10

this is wrong branch, CP will fail

/cherry-pick release-1.11

@knative-prow-robot
Copy link

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

this is wrong branch

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member Author

/cc @creydr

@knative-prow knative-prow bot requested a review from creydr July 31, 2023 08:33
creydr
creydr approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/check-cla

3 similar comments
@pierDipi
Copy link
Member Author

/check-cla

@pierDipi
Copy link
Member Author

/check-cla

@pierDipi
Copy link
Member Author

/check-cla

@krsna-m
Copy link

krsna-m commented Jul 31, 2023

/easycla

@knative-prow knative-prow bot merged commit 6b6046a into knative-extensions:main Jul 31, 2023
23 checks passed
@knative-prow-robot
Copy link

@pierDipi: #559 failed to apply on top of branch "release-1.10":

Applying: Support HTTPS in StartSenderToResource
Using index info to reconstruct a base tree...
M	pkg/eventshub/options.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/eventshub/options.go
CONFLICT (content): Merge conflict in pkg/eventshub/options.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Support HTTPS in StartSenderToResource
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link

@pierDipi: new pull request created: #560

In response to this:

/cherry-pick release-1.10

this is wrong branch, CP will fail

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierDipi @knative-prow-robot @krsna-m @creydr