Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10] Fix unit tests #556

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[release-1.10] Fix unit tests #556

merged 1 commit into from
Jul 28, 2023

Conversation

pierDipi
Copy link
Member

As per title

@pierDipi
Fix unit tests
bcccfc6 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested review from krsna-m and psschwei July 28, 2023 07:50
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2023
ReToCode
ReToCode approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for tests
/lgtm

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@knative-prow knative-prow bot merged commit 288a740 into knative-extensions:release-1.10 Jul 28, 2023
20 of 23 checks passed
@pierDipi pierDipi deleted the fix-unit-tests branch July 28, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@krsna-m krsna-m Awaiting requested review from krsna-m

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @ReToCode