Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10] Add name to port #554

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[release-1.10] Add name to port #554

merged 1 commit into from
Jul 28, 2023

Conversation

pierDipi
Copy link
Member

@pierDipi
Add name to port
97857ae 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested review from cardil and psschwei July 28, 2023 07:16
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2023
@pierDipi
Copy link
Member Author

/cherry-pick release-1.9

@knative-prow-robot
Copy link

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member Author

/cc @creydr @ReToCode

@knative-prow knative-prow bot requested review from creydr and ReToCode July 28, 2023 07:20
ReToCode
ReToCode approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a reviewer here, but /lgtm 😃

@knative-prow
Copy link

knative-prow bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@knative-prow knative-prow bot merged commit ca17404 into knative-extensions:release-1.10 Jul 28, 2023
13 of 18 checks passed
@knative-prow-robot knative-prow-robot mentioned this pull request Jul 28, 2023
Merged
@knative-prow-robot
Copy link

@pierDipi: new pull request created: #555

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@cardil cardil Awaiting requested review from cardil

@psschwei psschwei Awaiting requested review from psschwei

@creydr creydr Awaiting requested review from creydr

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @knative-prow-robot @ReToCode