Add hold annotation for istio-proxy (#576)

* Add hold annotation for istio-proxy * Fix test --------- Co-authored-by: Martin Gencur <[email protected]>
knative-extensions · Aug 17, 2023 · 39774f1 · 39774f1
1 parent a7237b0
commit 39774f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/pkg/eventshub/eventshub_test.go b/pkg/eventshub/eventshub_test.go
@@ -154,6 +154,7 @@ func ExampleIstioAnnotation() {
 	//   labels:
 	//     app: eventshub-hubhub
 	//   annotations:
+	//       proxy.istio.io/config: "{ 'holdApplicationUntilProxyStarts': true }"
 	//       sidecar.istio.io/inject: "true"
 	//       sidecar.istio.io/rewriteAppHTTPProbers: "true"
 	// spec:

diff --git a/pkg/manifest/options.go b/pkg/manifest/options.go
@@ -86,6 +86,7 @@ func WithIstioPodAnnotations(cfg map[string]interface{}) {
 	podAnnotations := map[string]interface{}{
 		"sidecar.istio.io/inject":                "true",
 		"sidecar.istio.io/rewriteAppHTTPProbers": "true",
+		"proxy.istio.io/config":                  "{ 'holdApplicationUntilProxyStarts': true }",
 	}
 
 	WithAnnotations(podAnnotations)(cfg)