Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Ingress status with reason when reconcile failed #791

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Set Ingress status with reason when reconcile failed #791

merged 1 commit into from
Mar 10, 2022

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Mar 10, 2022

As per title, this patch changes to set Ingress status with reason when reconcile failed.

After this patch controller sets the status as below:

$ kubectl get dm
NAME                                        URL               READY     REASON
domainmapping.serving.knative.dev/foo.com   https://foo.com   Unknown   ReconcileIngressFailed

$ kubectl get king foo.com 
NAME      READY     REASON
foo.com   Unknown   ReconcileIngressFailed

$ kubectl describe dm foo.com
  ...
    Message:               failed to translate ingress: failed to fetch secret: secret "invalid-secret" not found
    Reason:                ReconcileIngressFailed
    Status:                Unknown
    Type:                  IngressReady

Fix #790

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2022
@nak3
Copy link
Contributor Author

nak3 commented Mar 10, 2022

I will add unit test later (separate PR) as it needs a lot of work due to #145

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #791 (96968a2) into main (55ad3b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #791   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files          18       18           
  Lines         749      749           
=======================================
  Hits          548      548           
  Misses        165      165           
  Partials       36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ad3b3...96968a2. Read the comment docs.

@nak3
Copy link
Contributor Author

nak3 commented Mar 10, 2022

/cc @ZhiminXiang @carlisia

Copy link

@ZhiminXiang ZhiminXiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1b3971e into knative-extensions:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller does not set any status when failed to reconcile
3 participants