Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests for pkg/reconciler/ingress #145

Open
mattmoor opened this issue Aug 11, 2020 · 12 comments
Open

unit tests for pkg/reconciler/ingress #145

mattmoor opened this issue Aug 11, 2020 · 12 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mattmoor
Copy link
Contributor

I noticed there are no unit tests in https://github.com/knative-sandbox/net-kourier/tree/master/pkg/reconciler/ingress
@mattmoor mattmoor added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 11, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2020
@nak3
Copy link
Contributor

nak3 commented Nov 10, 2020

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2020
@github-actions
Copy link

github-actions bot commented Feb 8, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2021
@nak3
Copy link
Contributor

nak3 commented Feb 8, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2021
@nak3 nak3 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2021
@nak3 nak3 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2021
@nak3 nak3 reopened this Mar 10, 2022
@nak3 nak3 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2022
@nak3 nak3 added this to the v1.4.0 milestone Mar 10, 2022
@nak3 nak3 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 10, 2022
@nak3
Copy link
Contributor

nak3 commented Mar 10, 2022

The test can be added by referring other repos like

@nak3 nak3 mentioned this issue Mar 10, 2022
Merged
@carlisia
Copy link
Member

/remove-lifecycle stale

@carlisia carlisia modified the milestones: v1.4.0, v1.6.0 Jun 10, 2022
@carlisia
Copy link
Member

/help-wanted

@nak3 nak3 removed this from the v1.6.0 milestone Jul 13, 2022
@nak3 nak3 added this to the v1.7.0 milestone Jul 13, 2022
@xiangpingjiang
Copy link

/assign

@dprotaso dprotaso removed this from the v1.7.0 milestone Sep 15, 2023
@xiangpingjiang xiangpingjiang removed their assignment Sep 29, 2023
@aliok
Copy link
Member

aliok commented May 22, 2024

/unassign xiangpingjiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@carlisia @dprotaso @aliok @nak3 @mattmoor @knative-prow-robot @xiangpingjiang