Rename knative-sandbox to knative-extensions

[davidhadas]

This is an automated PR to replace knative-sandbox strings with knative-extensions

[codecov]

Codecov Report

Merging #1371 (80cc354) into main (842e5c8) will not change coverage.
Report is 31 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1371   +/-   ##
=======================================
  Coverage   68.26%   68.26%           
=======================================
  Files          39       39           
  Lines        2373     2373           
=======================================
  Hits         1620     1620           
  Misses        673      673           
  Partials       80       80           

[matzew]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidhadas]

This PR fails due to shellcheck tests unrelated to the renaming.
See https://github.com/knative-extensions/eventing-kafka/actions/runs/5758835365/job/15611946836?pr=1371

Please fix the project code such that it passes shellcheck tests in a separate PR, once this is done we can get this PR going

[matzew]

@davidhadas I don't see what's wrong (or why the other PRs go in just fine, like updates of dependencies)

[davidhadas]

@davidhadas I don't see what's wrong (or why the other PRs go in just fine, like updates of dependencies)

My best guess (and maybe @upodroid can confirm or correct me) is that the productivity team made some changes at some past time. Maybe they added shellcheck tests or maybe they changed the shellcheck configuration. As a result, some repositories became non compliant with respect to the shellcheck tests.

However, these tests are performed only when someone changes a file, so any file not changed since the productivity team made the changes goes unnoticed. Once someone make any change in a file which fail these tests, the tests are performed and the PR fail.

If this is true, I think this process in productivity should change - the process should not rely on future PRs failing as it leads to a very long tail of failing PRs and confused developers.

But as I said, this is nothing more than my working theory :)

[creydr]

/override "style / suggester / github_actions"
/override "style / suggester / shell"

[knative-prow]

@creydr: Overrode contexts on behalf of creydr: style / suggester / github_actions, style / suggester / shell

In response to this:

/override "style / suggester / github_actions"
/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.