Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update eventing-kafka-broker-eventing nightly #3231

Conversation

knative-automation
Copy link
Contributor

/assign @knative-sandbox/eventing-wg-leads
/cc @knative-sandbox/eventing-wg-leads

Produced via:

for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

bumping knative.dev/eventing 6911db0...855fbed:
  > 855fbed Auto create events in channels (# 7089)
  > 0054bf3 Eventing TLS: Configure certificates to force rotate private keys (# 7104)

bumping knative.dev/eventing 6911db0...855fbed:
  > 855fbed Auto create events in channels (# 7089)
  > 0054bf3 Eventing TLS: Configure certificates to force rotate private keys (# 7104)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow
Copy link

knative-prow bot commented Jul 26, 2023

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative-sandbox/eventing-wg-leads.

Note that only knative-sandbox members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @knative-sandbox/eventing-wg-leads
/cc @knative-sandbox/eventing-wg-leads

Produced via:

for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
 curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

bumping knative.dev/eventing 6911db0...855fbed:
 > 855fbed Auto create events in channels (# 7089)
 > 0054bf3 Eventing TLS: Configure certificates to force rotate private keys (# 7104)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3231 (f8b33dc) into main (6794484) will decrease coverage by 0.02%.
Report is 4 commits behind head on main.
The diff coverage is 64.28%.

@@             Coverage Diff              @@
##               main    #3231      +/-   ##
============================================
- Coverage     63.61%   63.60%   -0.02%     
  Complexity      775      775              
============================================
  Files           170      170              
  Lines         11948    11957       +9     
  Branches        250      250              
============================================
+ Hits           7601     7605       +4     
- Misses         3770     3775       +5     
  Partials        577      577              
Flag Coverage Δ
java-unittests 80.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
control-plane/pkg/contract/contract.pb.go 7.41% <0.00%> (-0.04%) ⬇️
control-plane/pkg/reconciler/broker/broker.go 71.92% <100.00%> (+0.05%) ⬆️
control-plane/pkg/reconciler/channel/channel.go 69.10% <100.00%> (+0.05%) ⬆️
...ntrol-plane/pkg/reconciler/channel/v2/channelv2.go 70.96% <100.00%> (+0.04%) ⬆️
control-plane/pkg/reconciler/sink/kafka_sink.go 74.13% <100.00%> (+0.08%) ⬆️

@creydr
Copy link
Contributor

creydr commented Jul 27, 2023

/retest

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
@creydr
Copy link
Contributor

creydr commented Jul 27, 2023

/retest

2 similar comments
@creydr
Copy link
Contributor

creydr commented Jul 27, 2023

/retest

@creydr
Copy link
Contributor

creydr commented Jul 27, 2023

/retest

@knative-prow knative-prow bot merged commit d658e9d into knative-extensions:main Jul 27, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants