This repository has been archived by the owner on Jun 17, 2018. It is now read-only.
Adds ability to set selectedView when setting a custom view #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deallocates customView before updating based on selection state to avoid a memory leak
|
I could really use something like this as well. I think it could be implemented a bit differently, to avoid attaching multiple views, but this feature in general is really important. (I would simply create a SelectableCustomView protocol, that customView has to implement, which would expose an isSelected variable, or something, that would be used to trigger changes within the custom view itself) @kitasuke Any chance something like this could make it into the project? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fixes issue #347