Skip to content
This repository has been archived by the owner on Jun 17, 2018. It is now read-only.

Disable auto-select by swiping MenuItem on Standard mode #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

t
Copy link
Contributor

@t t commented Feb 10, 2017

Related: #212

Please see below GIF animation, user is trying to see tab0 (the first tab) by swiping menu. but always back to tab4 by auto select and never see tab0.

Original
org0

I guess most of users don't expect such behaviour on standard mode (and centerItem is false), so I don't make option, just disabled auto-select on the mode.

Fix
fix0

but If you think to need to keep current behaviour, I will add option to keep it.

@kitasuke
Copy link
Owner

Thanks for your PR!
This library is not designed for that case, so disabling auto-select is not preferred.
Can you add new option instead?

@t
Copy link
Contributor Author

t commented Feb 11, 2017

@kitasuke sure, I will add.

@t
Copy link
Contributor Author

t commented May 28, 2017

@kitasuke Sorry for no-update long time. Finally, I added isAutoSelectAtScrollEnd option to MenuViewCustomizable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants