Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back to top button #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amrzaki2000
Copy link

@amrzaki2000 amrzaki2000 commented Mar 12, 2021

Related Issuse

  • Info about Issue or bug

Closes: #37

Describe the changes you've made

  • Added back to top button to the pages of the website.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Screenshots

Original Updated
**original screenshot
image
** updated screenshot
image

@amrzaki2000
Copy link
Author

amrzaki2000 commented Mar 12, 2021

@CodesbyUnnati @khannakshat7 kindly review my pull request
Thank you 🙏🏻

@CodesbyUnnati
Copy link
Collaborator

Your code is showing conflicts..Please resolve it,

@amrzaki2000
Copy link
Author

Your code is showing conflicts..Please resolve it,

@CodesbyUnnati
Resolved

@amrzaki2000
Copy link
Author

@CodesbyUnnati

@khannakshat7
Copy link
Owner

@amrzaki2000 Please commit only the changed files don't commit all the files

@khannakshat7
Copy link
Owner

It is causing conflicts

@CodesbyUnnati
Copy link
Collaborator

image
Your PR will be merged when the conflicts are resolved, Pl resolve the conflicts to get your PR merged. :)

@amrzaki2000
Copy link
Author

Okay I'll resolve the conflicts

@arpit456jain
Copy link
Contributor

@amrzaki2000 are you working on this ?if yes no problem . If not I want to work on this.

@arpit456jain
Copy link
Contributor

@amrzaki2000 are you working on this ?if yes no problem . If not I want to work on this.

@khannakshat7 can I work on this.?

@khannakshat7
Copy link
Owner

@amrzaki2000 Pl. resolve the conflicts so that we can merge

@mansijain980
Copy link

@khannakshat7
i would like to work on it . Please assign it to me.

@arpit456jain
Copy link
Contributor

@khannakshat7
i would like to work on it . Please assign it to me.

@mansijain980 its already added.

@mansijain980
Copy link

@khannakshat7
i would like to work on it . Please assign it to me.

@mansijain980 its already added.

ITs has some conflicts i think

@arpit456jain
Copy link
Contributor

I had added it some days before my PR got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GSSoC '21] Create back to top button
5 participants